This is the mail archive of the
mailing list for the libstdc++ project.
Re: your patch
- To: mark at codesourcery dot com
- Subject: Re: your patch
- From: Loren James Rittle <rittle at latour dot rsch dot comm dot mot dot com>
- Date: Wed, 13 Jun 2001 17:48:26 -0500 (CDT)
- CC: dave at hiauly1 dot hia dot nrc dot ca, bkoz at redhat dot com, dave dot anglin at nrc dot ca, gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
- References: <firstname.lastname@example.org>
- Reply-to: rittle at labs dot mot dot com
In article <email@example.com>,
Mark Mitchell <firstname.lastname@example.org> writes:
> Threads are hairy. Cross-platform threads more so. Unfortunately,
> I do not understand this code very well. It looks sane enough to me,
> but we need more eyes.
> We definitely need a review from at least one of, and probably
> both of, Loren and Benjamin. Please look at this very, very carefully
> to convince yourselves that this code is an improvement over what is
> currently there. Try to think about race conditions, etc. If this
> is only to fix HPUX 10, think about whether or not this patch
> is likely to screw up on other more common platforms.
> Loren, Benjamin, please let me know what you think ASAP.
The patch is OK by me. It can't possibly break any modern pthread
implementation which allows static initialization of mutex.
Any other common platform that uses dynamic mutex initialization is
currently broken thus David's patch can only be an improvement in
quality for those platforms.