This is the mail archive of the libstdc++@gcc.gnu.org mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: your patch


In article <264530000.992465933@gandalf.codesourcery.com>,
Mark Mitchell <mark@codesourcery.com> writes:

> Threads are hairy.  Cross-platform threads more so.  Unfortunately,
> I do not understand this code very well.  It looks sane enough to me,
> but we need more eyes.

> We definitely need a review from at least one of, and probably
> both of, Loren and Benjamin.  Please look at this very, very carefully
> to convince yourselves that this code is an improvement over what is
> currently there.  Try to think about race conditions, etc.  If this
> is only to fix HPUX 10, think about whether or not this patch
> is likely to screw up on other more common platforms.

> Loren, Benjamin, please let me know what you think ASAP.

The patch is OK by me.  It can't possibly break any modern pthread
implementation which allows static initialization of mutex.

Any other common platform that uses dynamic mutex initialization is
currently broken thus David's patch can only be an improvement in
quality for those platforms.

Regards,
Loren


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]