This is the mail archive of the
libstdc++@gcc.gnu.org
mailing list for the libstdc++ project.
Re: libstdc++ test framework, minor improvement
- To: "Zack Weinberg" <zackw at stanford dot edu>
- Subject: Re: libstdc++ test framework, minor improvement
- From: Gabriel Dos Reis <Gabriel dot Dos-Reis at cmla dot ens-cachan dot fr>
- Date: 03 Apr 2001 01:47:29 +0200
- Cc: Gabriel Dos Reis <Gabriel dot Dos-Reis at cmla dot ens-cachan dot fr>, gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
- Organization: CMLA, ENS Cachan -- CNRS UMR 8536 (France)
- References: <20010402143617.R19282@stanford.edu> <flu247dkg7.fsf@sel.cmla.ens-cachan.fr> <20010402163128.T19282@stanford.edu>
"Zack Weinberg" <zackw@Stanford.EDU> writes:
| On Tue, Apr 03, 2001 at 12:07:52AM +0200, Gabriel Dos Reis wrote:
| >
| > But given the pressing state, I guess it is OK you put your patch in
| > (mainline and bracnh). I'll manage later to get sync with official
| > dejagnu source.
|
| Mainline and branch libstdc++.exp are not the same.
Oh, weird... I just noticed that they effectively diverge but I'm
unable to find corresponding ChangeLog entries...
| ... Should I put the
| patch on the branch anyway? Should I just copy mainline to branch?
Since your patch concerns only dg-test which is the same in the two
versions, it is OK you apply your patch.
Before copying mainline to branch, I need to figure out why
the following change was made:
*************** proc libstdc++-dg-init { args } {
*** 61,75 ****
# mkcheck.in used to output these information.
set output [remote_exec host $lib_env(CXX) -v]
! if { [lindex $output 0] == 0 } {
! set output [lindex $output 1]
! regexp "gcc version.*$" $output version
! regsub "\n+" $version "" version
! clone_output "Compiler: $version"
! clone_output "Compiler flags: $lib_env(CXXFLAGS)"
! } else {
! perror "Cannot determine compiler version: [lindex $output 1]"
! }
}
## dg.exp callback. Called from dg-test to run PROGRAM.
--- 61,76 ----
# mkcheck.in used to output these information.
set output [remote_exec host $lib_env(CXX) -v]
! # XXX don't try clever formatting hacks at the moment
! # if { [lindex $output 0] == 0 } {
! # set output [lindex $output 1]
! # regexp "gcc version.*$" $output version
! # regsub "\n+" $version "" version
! # clone_output "Compiler: $version"
! # clone_output "Compiler flags: $lib_env(CXXFLAGS)"
! # } else {
! # perror "Cannot determine compiler version: [lindex $output 1]"
! # }
}
Benjamin, do you have an idea?
-- Gaby