This is the mail archive of the libstdc++@sources.redhat.com mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: V3 PATCH: Turn on --enable-cstdio=stdio by default


Hi Mark,

Something is not quite right with this part of this patch:

2000-11-16  Mark Mitchell  <mark@codesourcery.com>

        * acinclude.m4 (GLIBCPP_ENABLE_CSTDIO): Make 
        --enable-cstdio=stdio the default.
	[...]

> I should have said "bootstrapped/tested on i686-pc-linux-gnu".

Did you check to ensure that the correct files were actually mapped
in for the new default? ;-)

I find that the patch below is needed or else I continue to get libio
as the default.  libstdc++-v3 build directory deleted, reconfigured
(by rerunning top-level make), rebuild and tested on
i686-unknown-freebsd3.4.

2000-11-17  Loren J. Rittle  <ljrittle@acm.org>

	* acinclude.m4 (GLIBCPP_ENABLE_CSTDIO): Correct last patch
	to ``make --enable-cstdio=stdio the default''.
	* libstdc++-v3/aclocal.m4: Rebuilt.
	* libstdc++-v3/configure: Rebuilt.

Index: libstdc++-v3/acinclude.m4
===================================================================
RCS file: /cvs/gcc/egcs/libstdc++-v3/acinclude.m4,v
retrieving revision 1.93
diff -c -r1.93 acinclude.m4
*** acinclude.m4	2000/11/17 01:04:00	1.93
--- acinclude.m4	2000/11/17 16:56:24
***************
*** 1222,1238 ****
  dnl GLIBCPP_ENABLE_CSTDIO
  dnl --enable-cstdio=libio sets config/c_io_libio.h and friends
  dnl 
! dnl default is libio
  dnl
  AC_DEFUN(GLIBCPP_ENABLE_CSTDIO, [
    AC_MSG_CHECKING([for cstdio to use])
    AC_ARG_ENABLE(cstdio,
!   [  --enable-cstdio        enable GNU libio for target io package. (default)
       --enable-cstdio=LIB    use LIB target-speific io package.], 
    if test x$enable_cstdio = xno; then
!      enable_cstdio=libio
    fi,
!      enable_cstdio=libio)
  
    enable_cstdio_flag=$enable_cstdio
  
--- 1222,1238 ----
  dnl GLIBCPP_ENABLE_CSTDIO
  dnl --enable-cstdio=libio sets config/c_io_libio.h and friends
  dnl 
! dnl default is stdio
  dnl
  AC_DEFUN(GLIBCPP_ENABLE_CSTDIO, [
    AC_MSG_CHECKING([for cstdio to use])
    AC_ARG_ENABLE(cstdio,
!   [  --enable-cstdio        enable stdio for target io package. (default)
       --enable-cstdio=LIB    use LIB target-speific io package.], 
    if test x$enable_cstdio = xno; then
!      enable_cstdio=stdio
    fi,
!      enable_cstdio=stdio)
  
    enable_cstdio_flag=$enable_cstdio
  

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]