This is the mail archive of the libstdc++@sources.redhat.com mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: solaris status



Hey Phil.

Here are a couple of comments.

> I'm thinking two things:  first, more of the wide-character-using stuff
> should be conditionally compiled, based on _GLIBCPP_USE_WCHAR_T.  

Yep. I'm sure this will have to be done: be pretty fearless about
this. If we can't do wchar_t support well, then we shouldn't do it at
all. The current sources have kind of lost this delineation, which is
a bug: it should be restored.

> Second, to
> aid in porting, might we add --disable-wchar to configure?  That would
> disable _GLIBCPP_USE_WCHAR_T even if the necessary support functions were
> present.

Please. I've had to hack around this myself. It'll be easier for all
concerned if we can explicitly disable this stuff.



More bits.

libio/Makefile.am: the c_codecvt.c file should be conditionally
compiled when _GLIBCPP_USE_WCHAR_T etc. As you've noticed, the libio
Makefiles are a bit wonky right now, as we have

- files that need to be compiled whenever compiling libio
- files that need to be compiled when compiling on hosts with old libios
- files that need to be compiled when compiling libio for wchar_t

This can be better organized. (Surprisingly, it's better organized
than the first crack at this, around the libio merge July 4, but it
clearly has a way to go..) Hmm. Perhaps the macros should be re-named
to actually reflect what's going on? (Just a thought :) )

_IO_MTSAFE_IO: would it be better to flip this on at configure time
instead explicitly wiring it into _G_config.h? That might be easiest,
as this is pretty straightforward autoconf hackery...

_IO_wide_data: Yeah. You should be able to just do a dummy declaration
(see the config work for mbstate_t (see bits/std_cwchar.h as well.)

64-bit types: Just make these typedefs dependent on wchar_t, maybe.


I'm not quite sure what to do with the cdefs.h problem. What are the
errors if it is not included? What's missing?


thanks,
benjamin

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]