This is the mail archive of the libstdc++@sourceware.cygnus.com mailing list for the libstdc++ project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: patch: remaining -Wall warnings


Michael Cook <cook@sightpath.com> writes:

> The char_traits<wchar_t>::eof() value is int_type(-1), which ends up
> being the same (in my case, at least) as if `return 0xffffffff' had
> been written.

Well, then define it as 0xffffffff.  Or correctly, use WEOF.

> My patch changed that test to `_M_c!=int_type(-2)' on the assumption
> that _M_c was never intended to have a value <-2.

Which is a reasonable thing to do if -2 is used as a magic bitpattern.

-- 
---------------.      drepper at gnu.org  ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \    ,-------------------'   \  Sunnyvale, CA 94089 USA
Cygnus Solutions `--' drepper at cygnus.com   `------------------------

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]