This is the mail archive of the libstdc++@sourceware.cygnus.com mailing list for the libstdc++ project. See the libstdc++ home page for more information.

[Date Prev][Date Next][Thread Prev][Thread Next]
[Date Index] [Subject Index] [Author Index] [Thread Index]

Re: typo in std_memory.h


Thanks for your patch Ryszard. Can you do me a favor though? Can you post
your patch as the output of diff -c -p? Although this is a small patch and
pretty easy to grok, using some of the style details from the egcs project
will prove useful in the future: 

http://egcs.cygnus.com/contribute.html

Using these guidlines the patch might look like this:

1998-10-28  Ryszard Kabatek  <kabatek@chemie.uni-halle.de>

	* stl/bits/std_memory.h: Fix typo.

Index: stl/bits/std_memory.h
===================================================================
RCS file: /cvs/cvsfiles/unsupported/isolib/stl/bits/std_memory.h,v
retrieving revision 1.4
diff -c -p -r1.4 std_memory.h
*** std_memory.h        1998/07/24 18:42:06     1.4
--- std_memory.h        1998/10/28 17:33:39
*************** public:
*** 90,96 ****
    auto_ptr(auto_ptr_ref<_Tp> __ref) __STL_NOTHROW
      : _M_ptr(__ref._M_ptr) {}
    template <class _Tp1> operator auto_ptr_ref<_Tp1>() __STL_NOTHROW
!     { return auto_ptr_ref<_Tp>(this.release()); }
    template <class _Tp1> operator auto_ptr<_Tp1>() __STL_NOTHROW
      { return auto_ptr<_Tp1>(this->release()) }

--- 90,96 ----
    auto_ptr(auto_ptr_ref<_Tp> __ref) __STL_NOTHROW
      : _M_ptr(__ref._M_ptr) {}
    template <class _Tp1> operator auto_ptr_ref<_Tp1>() __STL_NOTHROW
!     { return auto_ptr_ref<_Tp>(this->release()); }
    template <class _Tp1> operator auto_ptr<_Tp1>() __STL_NOTHROW
      { return auto_ptr<_Tp1>(this->release()) }
 

I'm thinking that this info should probably appear on the web page as
well.

Thanks again,
-Benjamin

On Wed, 28 Oct 1998, Ryszard Kabatek wrote:
> libstdc++-2.90.1/stl/bits/std_memory.h:
>     { return auto_ptr_ref<_Tp>(this.release()); }
> 
>     this.release() --> this->release()
> 
>     { return auto_ptr_ref<_Tp>(this->release()); }