libstdc++/62: stl_rope.h has many mis-ordered initializers

[pbd at op dot net]

>Number:         62
>Category:       libstdc++
>Synopsis:       stl_rope.h has many mis-ordered initializers
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    unassigned
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue May 30 10:17:00 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator:     Paul Barton-Davis <pbd@op.net>
>Release:        unknown-1.0
>Organization:
>Environment:
irrelevant
>Description:
stl_rope.h is full of mis-ordered initializers. 
I include a patch as a "file attachment"
that fixes all of the mis-orderings
that I have come across to date.

BTW, the prescence of these problems suggests to me that
the libstdc++ developers do not compile with -Wall. 
It would be a good idea, I think.
>How-To-Repeat:
Run gcc with -Wall on a file that includes stl_rope.h
>Fix:
apply the patch enclosed.
>Release-Note:
>Audit-Trail:
>Unformatted:
----gnatsweb-attachment----
Content-Type: application/octet-stream; name="stl_patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="stl_patch"

LS0tIHN0bF9yb3BlLmgJV2VkIFNlcCAgMiAxMzoyNTowNSAxOTk4CisrKyAvdXNyL2xvY2FsL2lu
Y2x1ZGUvZysrLTMvc3RsX3JvcGUuaAlUdWUgTWF5IDMwIDEyOjA3OjI0IDIwMDAKQEAgLTM4Niw4
ICszODYsOSBAQAogICAgIHR5cGVkZWYgX1JvcGVfcmVwX2Jhc2U8X0NoYXJULF9BbGxvYz46OmFs
bG9jYXRvcl90eXBlIGFsbG9jYXRvcl90eXBlOwogICAgIF9Sb3BlX1JvcGVSZXAoX1RhZyBfX3Qs
IGludCBfX2QsIGJvb2wgX19iLCBzaXplX3QgX19zaXplLAogICAgICAgICAgICAgICAgICAgYWxs
b2NhdG9yX3R5cGUgX19hKQotICAgICAgICA6IF9NX3RhZyhfX3QpLCBfTV9kZXB0aChfX2QpLCBf
TV9pc19iYWxhbmNlZChfX2IpLCBfTV9jX3N0cmluZygwKSwKLSAgICAgICAgICBfUm9wZV9yZXBf
YmFzZTxfQ2hhclQsX0FsbG9jPihfX3NpemUsIF9fYSkKKyAgICAgICAgOiBfUm9wZV9yZXBfYmFz
ZTxfQ2hhclQsX0FsbG9jPihfX3NpemUsIF9fYSksCisJICBfTV90YWcoX190KSwgX01faXNfYmFs
YW5jZWQoX19iKSwgX01fZGVwdGgoX19kKSwgX01fY19zdHJpbmcoMCkKKyAgICAgICAgICAKICAg
ICB7CiAjICAgICAgIGlmbmRlZiBfX0dDCiAgICAgICAgICAgICBfTV9yZWZjb3VudCA9IDE7CkBA
IC01NjIsOCArNTYzLDggQEAKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLyogZG9l
c24ndCBtYXR0ZXIuICAgICAgICAgICAgICAgKi8KICAgICB0eXBlZGVmIF9Sb3BlX3JlcF9iYXNl
PF9DaGFyVCxfQWxsb2M+OjphbGxvY2F0b3JfdHlwZSBhbGxvY2F0b3JfdHlwZTsKICAgICBfUm9w
ZV9Sb3BlTGVhZihfX0dDX0NPTlNUIF9DaGFyVCogX19kLCBzaXplX3QgX19zaXplLCBhbGxvY2F0
b3JfdHlwZSBfX2EpCi0gICAgICAgIDogX01fZGF0YShfX2QpCi0gICAgICAgICwgX1JvcGVfUm9w
ZVJlcDxfQ2hhclQsX0FsbG9jPihfU19sZWFmLCAwLCB0cnVlLCBfX3NpemUsIF9fYSkKKyAgICAg
ICAgOiBfUm9wZV9Sb3BlUmVwPF9DaGFyVCxfQWxsb2M+KF9TX2xlYWYsIDAsIHRydWUsIF9fc2l6
ZSwgX19hKSwKKwkgIF9NX2RhdGEoX19kKQogICAgICAgICB7CiAgICAgICAgIF9fc3RsX2Fzc2Vy
dChfX3NpemUgPiAwKTsKICAgICAgICAgaWYgKF9TX2lzX2Jhc2ljX2NoYXJfdHlwZSgoX0NoYXJU
ICopMCkpIHsKQEAgLTU5MywxMCArNTk0LDEwIEBACiAgICAgX1JvcGVfUm9wZUNvbmNhdGVuYXRp
b24oX1JvcGVfUm9wZVJlcDxfQ2hhclQsX0FsbG9jPiogX19sLAogICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBfUm9wZV9Sb3BlUmVwPF9DaGFyVCxfQWxsb2M+KiBfX3IsCiAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIGFsbG9jYXRvcl90eXBlIF9fYSkKLSAgICAgIDogX01fbGVmdChf
X2wpLCBfTV9yaWdodChfX3IpCi0gICAgICAsIF9Sb3BlX1JvcGVSZXA8X0NoYXJULF9BbGxvYz4o
CisgICAgICA6IF9Sb3BlX1JvcGVSZXA8X0NoYXJULF9BbGxvYz4oCiAgICAgICAgICAgX1NfY29u
Y2F0LCBtYXgoX19sLT5fTV9kZXB0aCwgX19yLT5fTV9kZXB0aCkgKyAxLCBmYWxzZSwKLSAgICAg
ICAgICBfX2wtPl9NX3NpemUgKyBfX3ItPl9NX3NpemUsIF9fYSkKKyAgICAgICAgICBfX2wtPl9N
X3NpemUgKyBfX3ItPl9NX3NpemUsIF9fYSksCisgICAgICAgICBfTV9sZWZ0KF9fbCksIF9NX3Jp
Z2h0KF9fcikKICAgICAgIHt9CiAjIGlmbmRlZiBfX0dDCiAgICAgfl9Sb3BlX1JvcGVDb25jYXRl
bmF0aW9uKCkgewpAQCAtNjI5LDExICs2MzAsMTIgQEAKICAgICB0eXBlZGVmIF9Sb3BlX3JlcF9i
YXNlPF9DaGFyVCxfQWxsb2M+OjphbGxvY2F0b3JfdHlwZSBhbGxvY2F0b3JfdHlwZTsKICAgICBf
Um9wZV9Sb3BlRnVuY3Rpb24oY2hhcl9wcm9kdWNlcjxfQ2hhclQ+KiBfX2YsIHNpemVfdCBfX3Np
emUsCiAgICAgICAgICAgICAgICAgICAgICAgICBib29sIF9fZCwgYWxsb2NhdG9yX3R5cGUgX19h
KQotICAgICAgOiBfTV9mbihfX2YpCisgICAgICA6IF9Sb3BlX1JvcGVSZXA8X0NoYXJULF9BbGxv
Yz4oX1NfZnVuY3Rpb24sIDAsIHRydWUsIF9fc2l6ZSwgX19hKSwKKwlfTV9mbihfX2YpCiAjICAg
ICAgIGlmbmRlZiBfX0dDCiAgICAgICAsIF9NX2RlbGV0ZV93aGVuX2RvbmUoX19kKQogIyAgICAg
ICBlbmRpZgotICAgICAgLCBfUm9wZV9Sb3BlUmVwPF9DaGFyVCxfQWxsb2M+KF9TX2Z1bmN0aW9u
LCAwLCB0cnVlLCBfX3NpemUsIF9fYSkgeworICAgIHsgICAgCiAgICAgICAgIF9fc3RsX2Fzc2Vy
dChfX3NpemUgPiAwKTsKICMgICAgICAgaWZkZWYgX19HQwogICAgICAgICAgICAgaWYgKF9fZCkg
ewpAQCAtNjkzLDkgKzY5NSw5IEBACiAgICAgdHlwZWRlZiBfUm9wZV9yZXBfYmFzZTxfQ2hhclQs
X0FsbG9jPjo6YWxsb2NhdG9yX3R5cGUgYWxsb2NhdG9yX3R5cGU7CiAgICAgX1JvcGVfUm9wZVN1
YnN0cmluZyhfUm9wZV9Sb3BlUmVwPF9DaGFyVCxfQWxsb2M+KiBfX2IsIHNpemVfdCBfX3MsCiAg
ICAgICAgICAgICAgICAgICAgICAgICAgIHNpemVfdCBfX2wsIGFsbG9jYXRvcl90eXBlIF9fYSkK
LSAgICAgIDogX01fYmFzZShfX2IpCisgICAgICA6IF9Sb3BlX1JvcGVGdW5jdGlvbjxfQ2hhclQs
X0FsbG9jPih0aGlzLCBfX2wsIGZhbHNlLCBfX2EpIAorICAgICAgLAlfTV9iYXNlKF9fYikKICAg
ICAgICwgX01fc3RhcnQoX19zKQotICAgICAgLCBfUm9wZV9Sb3BlRnVuY3Rpb248X0NoYXJULF9B
bGxvYz4odGhpcywgX19sLCBmYWxzZSwgX19hKSAKICAgICB7CiAgICAgICAgIF9fc3RsX2Fzc2Vy
dChfX2wgPiAwKTsKICAgICAgICAgX19zdGxfYXNzZXJ0KF9fcyArIF9fbCA8PSBfX2ItPl9NX3Np
emUpOwpAQCAtNzY2LDE2ICs3NjgsMTYgQEAKICAgICBfTXlfcm9wZSogX01fcm9vdDsgICAgIC8v
IFRoZSB3aG9sZSByb3BlLgogICBwdWJsaWM6CiAgICAgX1JvcGVfY2hhcl9yZWZfcHJveHkoX015
X3JvcGUqIF9fciwgc2l6ZV90IF9fcCkgOgotICAgICAgICBfTV9wb3MoX19wKSwgX01fcm9vdChf
X3IpLCBfTV9jdXJyZW50X3ZhbGlkKGZhbHNlKSB7fQorICAgICAgICBfTV9wb3MoX19wKSwgX01f
Y3VycmVudF92YWxpZChmYWxzZSksIF9NX3Jvb3QoX19yKSB7fQogICAgIF9Sb3BlX2NoYXJfcmVm
X3Byb3h5KGNvbnN0IF9Sb3BlX2NoYXJfcmVmX3Byb3h5JiBfX3gpIDoKLSAgICAgICAgX01fcG9z
KF9feC5fTV9wb3MpLCBfTV9yb290KF9feC5fTV9yb290KSwgX01fY3VycmVudF92YWxpZChmYWxz
ZSkge30KKyAgICAgICAgX01fcG9zKF9feC5fTV9wb3MpLCAgX01fY3VycmVudF92YWxpZChmYWxz
ZSksIF9NX3Jvb3QoX194Ll9NX3Jvb3QpIHt9CiAgICAgICAgIC8vIERvbid0IHByZXNlcnZlIGNh
Y2hlIGlmIHRoZSByZWZlcmVuY2UgY2FuIG91dGxpdmUgdGhlCiAgICAgICAgIC8vIGV4cHJlc3Np
b24uICBXZSBjbGFpbSB0aGF0J3Mgbm90IHBvc3NpYmxlIHdpdGhvdXQgY2FsbGluZwogICAgICAg
ICAvLyBhIGNvcHkgY29uc3RydWN0b3Igb3IgZ2VuZXJhdGluZyByZWZlcmVuY2UgdG8gYSBwcm94
eQogICAgICAgICAvLyByZWZlcmVuY2UuICBXZSBkZWNsYXJlIHRoZSBsYXR0ZXIgdG8gaGF2ZSB1
bmRlZmluZWQgc2VtYW50aWNzLgogICAgIF9Sb3BlX2NoYXJfcmVmX3Byb3h5KF9NeV9yb3BlKiBf
X3IsIHNpemVfdCBfX3AsCiAgICAgICAgICAgICAgICAgICAgIF9DaGFyVCBfX2MpIDoKLSAgICAg
ICAgX01fcG9zKF9fcCksIF9NX3Jvb3QoX19yKSwgX01fY3VycmVudChfX2MpLCBfTV9jdXJyZW50
X3ZhbGlkKHRydWUpIHt9CisgICAgICAgIF9NX3BvcyhfX3ApLCBfTV9jdXJyZW50KF9fYyksIF9N
X2N1cnJlbnRfdmFsaWQodHJ1ZSksIF9NX3Jvb3QoX19yKSB7fQogICAgIGlubGluZSBvcGVyYXRv
ciBfQ2hhclQgKCkgY29uc3Q7CiAgICAgX1JvcGVfY2hhcl9yZWZfcHJveHkmIG9wZXJhdG9yPSAo
X0NoYXJUIF9fYyk7CiAgICAgX1JvcGVfY2hhcl9wdHJfcHJveHk8X0NoYXJULF9BbGxvYz4gb3Bl
cmF0b3ImICgpIGNvbnN0OwpAQCAtOTA4LDcgKzkxMCw3IEBACiAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgLy8gY2FjaGUgaXMgdmFsaWQgZm9yIHByZXZpb3VzIHBvc24u
CiAgICAgX1JvcGVfaXRlcmF0b3JfYmFzZSgpIHt9CiAgICAgX1JvcGVfaXRlcmF0b3JfYmFzZShf
Um9wZVJlcCogX19yb290LCBzaXplX3QgX19wb3MpCi0gICAgICA6IF9NX3Jvb3QoX19yb290KSwg
X01fY3VycmVudF9wb3MoX19wb3MpLCBfTV9idWZfcHRyKDApIHt9CisgICAgICA6IF9NX2N1cnJl
bnRfcG9zKF9fcG9zKSwgX01fcm9vdChfX3Jvb3QpLCBfTV9idWZfcHRyKDApIHt9CiAgICAgdm9p
ZCBfTV9pbmNyKHNpemVfdCBfX24pOwogICAgIHZvaWQgX01fZGVjcihzaXplX3QgX19uKTsKICAg
cHVibGljOgo=