This is the mail archive of the
java@gcc.gnu.org
mailing list for the Java project.
found redundant code in file natSystemProperties.cc
- From: "Martin Ettl" <ettl dot martin at gmx dot de>
- To: java at gcc dot gnu dot org
- Date: Tue, 28 Jul 2009 06:21:15 +0200
- Subject: found redundant code in file natSystemProperties.cc
Hello friends,
i have checked the sources of gcc-4.4.1 with the static code analysis tool cppcheck. It brought up an issue in file gcc-4.4.1/libjava/gnu/classpath/natSystemProperties.cc at line 278. Lets take a look at the sourcecode:
// ...
while (buffer != NULL)
{
if (getcwd (buffer, buflen) != NULL)
{
SET ("user.dir", buffer);
break;
}
if (errno != ERANGE)
break;
buflen = 2 * buflen;
char *orig_buf = buffer;
buffer = (char *) realloc (buffer, buflen);
if (buffer == NULL)
free (orig_buf);
}
278 if (buffer != NULL)
free (buffer);
....
Here the line 278 is redundant, because it is safe to deallocate a NULL-Pointer! In other words, the if-statement can be removed.
Best regards
Ettl Martin
--
Neu: GMX Doppel-FLAT mit Internet-Flatrate + Telefon-Flatrate
für nur 19,99 Euro/mtl.!* http://portal.gmx.net/de/go/dsl02