Re: Bug in JNI RegisterNatives?

[Juerg Lehni <juerg at scratchdisk dot com>]

Hi Tom,

Thank you for all the work on this.

Using a rewrite of my patch is fine.

I will try it out in the next days.

The patch looks good, but I found a little detail:

Shouldn't savehash be freed at the end of nathash_find?

	// free old table after rehash
	_Jv_Free (savehash);

I had this in my original patch.

Jürg

On 10.10.2006, at 01:38, Tom Tromey wrote:

> > > > > > "Juerg" == Juerg Lehni <juerg@scratchdisk.com> writes:
>
> Juerg> I am wondering wether this patch will eventally be included
> Juerg> I've submitted it more than 3 months ago, and nothing seems  
> to have
> Juerg> happened since.
>
> Juerg> Is there anything I need to do to get it accepted?
>
> I think your patch is too big to go in without an assignment.  And,
> given the proximity of 4.2, and the time needed to get the paperwork
> in order, I thought I would just rewrite it.
>
> Basically I just added a new class name field to the entries in the
> hash table.  Could you try this patch with your test case and let me
> know if it works?  If it does I will check it in.
>
> Thanks, and sorry for the difficulty here.
>
> Tom