Re: Marking JNI funtions extern

[Mark Wielaard <mark at klomp dot org>]

Hi,

On Thu, 2004-05-20 at 17:47, Tom Tromey wrote:
> >>>>> "Mark" == Mark Wielaard <mark@klomp.org> writes:
> 
> Mark> Is there a reason why gcjh -jni marks all JNI functions extern JNIEXPORT
> Mark> and not just JNIEXPORT?
> 
> Not that I know of.

OK in that case I propose the following patch:

2004-05-21  Mark Wielaard  <mark@klomp.org>

        * gjavah.c (print_stub_or_jni): Mark functions only JNIEXPORT, not
        extern.

The extern function modifiers were confusing the kaffe build process.
Tested by rebuilding both libjava and GNU Classpath (with
--enable-regen-headers), no regressions.

OK to commit?

Cheers,

Mark

Index: gjavah.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/java/gjavah.c,v
retrieving revision 1.114
diff -u -r1.114 gjavah.c
--- gjavah.c	30 Apr 2004 18:14:07 -0000	1.114
+++ gjavah.c	21 May 2004 10:45:32 -0000
@@ -1567,7 +1567,7 @@
 	return;
 
       if (flag_jni && ! stubs)
-	fputs ("extern JNIEXPORT ", stream);
+	fputs ("JNIEXPORT ", stream);
 
       /* If printing a method, skip to the return signature and print
 	 that first.  However, there is no return value if this is a

Attachment: signature.asc
Description: This is a digitally signed message part