This is the mail archive of the java@gcc.gnu.org mailing list for the Java project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: ClasspathFontPeer allows null transform

From: graydon hoare <graydon at redhat dot com>
To: Scott Gilbertson <scottg at mantatest dot com>
Cc: java at gcc dot gnu dot org
Date: Wed, 28 Jan 2004 15:18:35 -0500
Subject: Re: ClasspathFontPeer allows null transform
References: <00f801c3e5d9$b93db9c0$af16a8c0@mantatest.com>

Scott Gilbertson wrote:

I'm working on classpathifying the xlib peers so they'll work with the
latest code in cvs.  It's apparently working, but only because of a hack.

great!

ClasspathFontPeer doesn't put anything in its "transform" field when you
construct it with name,style,size.  I therefore get a null pointer exception
in java.awt.Font.equals, which doesn't check for a null transform in either
or both fonts being compared.

oops, sorry.

I guess the possible "proper" approaches are:
 1. make java.awt.Font.equals tolerant of a null transform in either or both
fonts
 2. make java.awt.Font.getTransform so it returns an identity transform if
the peer returns null
 3. change ClasspathFontPeer so it puts an identity transform in
"transform", rather than null

Got a preference?

personally? nothing aside from "whatever is most like what sun does". that's my tie-break rule for everything :)

-graydon

References:
- ClasspathFontPeer allows null transform
  - From: Scott Gilbertson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]