This is the mail archive of the
java@gcc.gnu.org
mailing list for the Java project.
Re: java.io.File compatibility problem.
- From: Tom Tromey <tromey at redhat dot com>
- To: gnustuff at thisiscool dot com
- Cc: Rutger Ovidius <ovid at mailandnews dot com>, Michael Koch <konqueror at gmx dot de>, java at gcc dot gnu dot org
- Date: 19 Oct 2003 14:39:49 -0600
- Subject: Re: java.io.File compatibility problem.
- References: <DBGDWTHDMFD2UHBPJOMLH2U05KJKI71.3f915dc1@p733>
- Reply-to: tromey at redhat dot com
>>>>> "Mohan" == Mohan Embar <gnustuff@thisiscool.com> writes:
Mohan> ...and get this approved:
Mohan> http://gcc.gnu.org/ml/java-patches/2003-q4/msg00122.html
Mohan> ...before putting out a new build.
You know better than me whether this should go in.
I don't have any major problems with it, just a formatting nit or two.
(In particular the "return" statement in dirExists is formatted
incorrectly according to GNU standards, and you should put comments
before code, not after.)
Is anybody reviewing Windows patches? If not, let's appoint you to do
that :-)
Tom