This is the mail archive of the
java@gcc.gnu.org
mailing list for the Java project.
Re: Build-Breaking MingW 3.3 Stuff
- From: Mohan Embar <gnustuff at thisiscool dot com>
- To: Andrew Haley <aph at redhat dot com>
- Cc: GCJ Java <java at gcc dot gnu dot org>, konqueror at gmx dot de
- Date: Sun, 13 Apr 2003 22:24:09 -0500
- Subject: Re: Build-Breaking MingW 3.3 Stuff
- Reply-to: gnustuff at thisiscool dot com
Hi Andrew,
> > (The code in question is placeholder, do-nothing code.)
>
>Okay. That sounds like it's fairly safe.
I looked at the code in question again and saw that the patch
in question affects code that is NOT placeholder, do-nothing code.
Many of the functions in this file are placeholder, but these ones
are not. I am terribly sorry for the misinformation.
This being said, the patch is trivial and hopefully, I can convince you
the pre-patch code is incorrect. The UNIX socket functions send()
and receive() each require a char* as their second parameter
which is the data to write or the read buffer, respectively. The
previously code passed a jbyteArray directly as this parameter
instead of using elements(jbyteArray), which is required to
gain access to the raw byte array. That's basically all the patch
is doing.
Oh, and come to think of it, this is NOT a Windows-specific patch.
The code is incorrect on all platforms, so you should be able to
run a regression test for this specific patch if you are so inclined.
Sorry again for the misinformation and thanks for putting up with me.
-- Mohan
http://www.thisiscool.com/
http://www.animalsong.org/