This is the mail archive of the
java@gcc.gnu.org
mailing list for the Java project.
Re: Possible awt patches
- From: Tom Tromey <tromey at redhat dot com>
- To: "Boehm, Hans" <hans_boehm at hp dot com>
- Cc: "'java at gcc dot gnu dot org'" <java at gcc dot gnu dot org>
- Date: 10 Feb 2003 17:05:47 -0700
- Subject: Re: Possible awt patches
- References: <75A9FEBA25015040A761C1F74975667DA1367D@hplex4.hpl.hp.com>
- Reply-to: tromey at redhat dot com
>>>>> "Hans" == Boehm, Hans <hans_boehm@hp.com> writes:
Hans> I've been trying to get the GUI version of my constructive reals
Hans> calculator to work with gcj.
Excellent.
Hans> If someone can verify that I'm not just covering up other
Hans> problems, I'll be happy to add ChangeLog entries and check them
Hans> in:
They all look reasonable to me.
Note that AWT (the base code and the Gtk peers) is 100% merged, so all
patches have to go in to Classpath as well. I can take care of this
though.
Hans> 1) setVisible calls didn't seem to invoke the right overridden
Hans> show calls. The comments seemed to imply that the current code
Hans> was incorrect.
I think I made this change (but failed to remove the comment, bleah)
on the theory that we shouldn't use deprecated methods in our
implementation. Compatibility is more important.
Hans> 4) Both TextField.getPreferredSize and TextArea.getPreferredSize
Hans> are apparently easily called before peers exist, and they
Hans> basically give up in that case. I added code to guess instead,
Hans> which gets me further, but is clearly wrong. Suggestions for a
Hans> real fix would be appreciated.
One thing to try would be to see what the JDK does.
Making a guess doesn't seem so bad to me. It seems like layout ought
to be recomputed once peers are made.
Tom