This is the mail archive of the java@gcc.gnu.org mailing list for the Java project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: am I not cool enough for you?

Andrew Haley <aph@cambridge.redhat.com> writes:
> However, "FIXME: little endian" is a bit worrying.  Is it really
> endian dependent?

No, actually, I fixed that FIXME and forgot to remove it -- that's
what longFromStackTraceBytes() does -- converts octet sequences into
jlongs in an endian-safe manner.


> You'll get alignment faults if you do this -- you can't cast a jbyte*
> to a jlong*.

Ah, crap, I forgot about that.


> printRawStackTrace copies from stackTraceBytes to a suitably aligned
> array.

That sounds like a much better idea. I'll reimplement and post a new
patch.

Any other things I should address?

  - a


-- 
Sick of HTML user interfaces?
www.xwt.org
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]