This is the mail archive of the java@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: patch to enable inet_addr() on Win32 [ok for mainline?]


Adam Megacz wrote:

>>Before this goes in on the mainline, please explore this alternative
>>with the Java folks and convince yourselves that there's really no
>>other fix.
>>    
>>
>
>Okay, I just took a look at this. Turns out that gcj's configury uses
>AC_CHECK_FUNCS, which doesn't work right when crosscompiling. 
>

Hmm. If that is the case for all cross targets then it is something we 
really need to fix.

>>If you add a comment -- and the patch is approved for the mainline --
>>the patch is also OK for the branch.
>>    
>>
>
>Here's the revised patch. Ok for mainline?
>

OK, but please make the comment into a full sentence (capital letter and 
".").

regards,

Bryce.

>  - a
>
>Index: java/net/natInetAddress.cc
>===================================================================
>RCS file: /cvs/gcc/gcc/libjava/java/net/natInetAddress.cc,v
>retrieving revision 1.18.18.1
>diff -u -r1.18.18.1 natInetAddress.cc
>--- java/net/natInetAddress.cc  4 Mar 2002 20:02:19 -0000       1.18.18.1
>+++ java/net/natInetAddress.cc  27 May 2002 22:54:40 -0000
>@@ -9,6 +9,7 @@
> details.  */
> 
> #include <config.h>
>+#include <platform.h>
> 
> #ifdef WIN32
> 
>Index: include/win32.h
>===================================================================
>RCS file: /cvs/gcc/gcc/libjava/include/win32.h,v
>retrieving revision 1.3.8.5
>diff -u -r1.3.8.5 win32.h
>--- include/win32.h     24 Apr 2002 01:04:45 -0000      1.3.8.5
>+++ include/win32.h     27 May 2002 22:54:40 -0000
>@@ -35,4 +35,8 @@
>    ARRAY and return the exact number of values stored.  */
> extern int backtrace (void **__array, int __size);
> 
>+// configure cannot correctly detect inet_addr due to Win32's
>+// oddball header naming scheme
>+#define HAVE_INET_ADDR
>+
> #endif /* __JV_WIN32_H__ */
>  
>



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]