This is the mail archive of the
java@gcc.gnu.org
mailing list for the Java project.
Re: PATCH: Parallel compilation of class files
- From: Alexandre Oliva <aoliva at redhat dot com>
- To: Mark Mitchell <mark at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org, java at gcc dot gnu dot org
- Date: 08 May 2002 22:41:37 -0300
- Subject: Re: PATCH: Parallel compilation of class files
- Organization: GCC Team, Red Hat
- References: <102040000.1020885871@gandalf.codesourcery.com>
On May 8, 2002, Mark Mitchell <mark@codesourcery.com> wrote:
> ! temporary_file_name = xmalloc (strlen (class_file_name)
> ! + strlen (".tmp") + 1);
> ! sprintf (temporary_file_name, "%s.tmp", class_file_name);
Consider using `concat (class_file_name, ".tmp");'
> ! if (rename (temporary_file_name, class_file_name) == -1)
> ! fatal_io_error ("can't create %s", class_file_name);
wouldn't it be appropriate to unlink the temporary file in this case?
--
Alexandre Oliva Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer aoliva@{cygnus.com, redhat.com}
CS PhD student at IC-Unicamp oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist Professional serial bug killer