This is the mail archive of the java@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: Analysis of Mauve failures - The final chapter


Mark Wielaard writes:
 > 
 >  {
 > +  if (! dimensions)
 > +    throw new java::lang::NullPointerException;
 >    jint ndims = dimensions->length;

No, this is wrong, there's no need to do this check.  The dereference
of dimensions will generate a SEGV and throw a NullPointerException,
unless it's running on a broken system that doesn't catch SEGV.  

The thing to do with such systems is to fix them, not add checks to
the library.

Andrew.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]