This is the mail archive of the java@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

relocate bits of posix.cc into natPosix*.cc?



posix.cc/posix.h define two functions: _Jv_select() and _Jv_gettimeofday().

_Jv_gettimeofday() is used only by natSystem.cc -- I propose that it
be moved into that file, and perhaps even inlined directly into
java::lang::System::currentTimeMillis().

_Jv_select() is used by natPlainSocketImpl.cc,
natPlainDatagramSocketImpl.cc, and natFileDescriptorPosix.cc, all of
which are POSIX-specific (see my last post recommending that we rename
the latter two to nat${PLATFORM}SocketImpl). I would suggest moving
_Jv_select() into natFileDescriptorPosix.cc and making it a global so
that it can be used in the natSocketImpl's.

posix.h would retain a definition for _Jv_select().

What do you all think?

  - a


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]