This is the mail archive of the java@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: gcj vs classpath merge status


"Aaron M. Renn" <arenn@urbanophile.com> writes:

> > If so, would it also be okay to remove the stream classes and make 
> > them inner classes (of PlainSocketImpl). That should clear them off 
> > the merge list. 
>  
> As they aren't public classes, I don't think this is necessary.  But 
> if you really want to, I would not object. (I personally don't care much 
> for inner classes all that much). 
>  
> I believe all of the easy parts of java.net are already merged.  What 
> remains is the native stuff, including the corresponding Java classes 
> and URL's.  I think. 

One other question on this.

Aaron wrote the classes with the GNU style for indentation applied to methods. The
current interpretation of the style guide (at least on the gcj
project) is to apply the indentation to the whole class.

This means that, strictly, some of the code in java.net should be
re-formatted.

I'm quite happy to submit an indentation patch before I do anything
else... should I?



Nic Ferrier


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]