Re: nogc.cc & darwin

[Bryce McKinlay <bryce at waitaki dot otago dot ac dot nz>]

Andreas Tobler wrote:

>
>Tom Tromey wrote:
>
>>>>>>>"Bryce" == Bryce McKinlay <bryce@waitaki.otago.ac.nz> writes:
>>>>>>>
>>Bryce> Sorry, I mislead you with my previous comment. GCJ is generating a call
>>Bryce> to sqrtf() from the Math.sqrt() calls in these files. I am not sure why
>>Bryce> it is calling sqrtf(), however, instead of sqrt() - this seems wrong
>>Bryce> because the arguments are double!
>>
>>I bet my recent builtin function call patch is broken :-(
>>
>
>builtin.c
>static tree
>sqrt_builtin (method_return_type, method_arguments)
>     tree method_return_type, method_arguments; 
>{
>  /* FIXME: this assumes that jdouble and double are the same.  */
>  tree fn = built_in_decls[BUILT_IN_SQRTF];
>
>Should it be here BUILT_IN_SQRT?
>

I think so - I suspect sqrt() can be used in place of sqrtf() but not 
vice-versa. I notice glibc doesn't declare any sqrtf() even though it 
still implements it.

regards

Bryce.