This is the mail archive of the java@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: question about -fno-optimize-static-class-initialization


Alexandre Petit-Bianco wrote:


> Does this help?


Yes, but I still need to work my way through the code.

First, is this really right?

- 
   if (index >= 0 && ! SET_P (before, index))
+ 
   /* We don't want to report and mark as non initialized flags
+ 
      the are, they will be marked initialized later on when
+ 
      assigned to `true.' */
+ 
   if ((STATIC_CLASS_INIT_OPT_P ()
+ 
        && ! LOCAL_CLASS_INITIALIZATION_FLAG_P (exp))
+ 
       && index >= 0 && ! SET_P (before, index))

This causes us to never emit the error messages unless 
STATIC_CLASS_INIT_OPT_P ().  Perhaps it should be:

+ 
   if (! LOCAL_CLASS_INITIALIZATION_FLAG_P (exp)
+ 
       && index >= 0 && ! SET_P (before, index))

(Also the comment does not make a lot of sense gramatically.)
-- 
	--Per Bothner
per@bothner.com   http://www.bothner.com/per/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]