This is the mail archive of the
java@gcc.gnu.org
mailing list for the Java project.
Re: Possible patch for miscompiled defer-pops
- To: Richard Henderson <rth at redhat dot com>
- Subject: Re: Possible patch for miscompiled defer-pops
- From: Andrew Haley <aph at cambridge dot redhat dot com>
- Date: Tue, 1 May 2001 21:14:07 +0100 (BST)
- Cc: Per Bothner <per at bothner dot com>, gcc-patches at gcc dot gnu dot org,java at gcc dot gnu dot org
- References: <m2ae4yn8ve.fsf@kelso.bothner.com><20010501125923.A9843@redhat.com>
Richard Henderson writes:
> On Mon, Apr 30, 2001 at 12:29:25AM -0700, Per Bothner wrote:
> > However, I have no idea if this actually *is* the correct fix,
> > since I do not know the protocol for dealing with deferred
> > pops in the middle-end.
>
> It is the correct action, however:
>
> > emit_label (label_rtx (LABELED_BLOCK_LABEL (exp)));
>
> I'm pretty sure that this should be
>
> expand_label (LABELED_BLOCK_LABEL (exp));
>
> which will also take care of the do_pending_stack_adjust.
> The only caveat would be the stack_block_stack machinations,
> which I don't really understand...
Um. I thought the reason emit_label rather than expand_label was used
in such cases was precisely to avoid machinations with binding levels.
Andrew.