This is the mail archive of the java@gcc.gnu.org mailing list for the Java project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: [PATCH] Java - allow compiling a compressed .jar/.zip archive

To: Jeff Sturm <jeff dot sturm at commerceone dot com>
Subject: Re: [PATCH] Java - allow compiling a compressed .jar/.zip archive
From: Per Bothner <per at bothner dot com>
Date: 26 Jan 2001 23:07:35 -0800
Cc: java-discuss at sources dot redhat dot com, gcc-patches at gcc dot gnu dot org
References: <m2wvbo1sac.fsf@kelso.bothner.com> <3A6D2BCF.E4FBC0AE@appnet.com><m28zo1h2ly.fsf@kelso.bothner.com> <3A6F2AD1.C94829E3@commerceone.com>

Jeff Sturm <jeff.sturm@commerceone.com> writes:

> This struct/buffer overlapping in read_zip_archive is ugly and
> fragile, clever as it may be.

I won't defend it very strongly.  It is probably faster and saves
some memory, but probably neither significantly so.    

I'm out of town so it is difficult to evaluate the best fix.
I have no objection to your fix, at least until we decide if
the code should be re-written.
-- 
	--Per Bothner
per@bothner.com   http://www.bothner.com/~per/

Follow-Ups:
- Re: [PATCH] Java - allow compiling a compressed .jar/.zip archive
  - From: Jeff Sturm

References:
- [PATCH] Java - allow compiling a compressed .jar/.zip archive
  - From: Per Bothner
- Re: [PATCH] Java - allow compiling a compressed .jar/.zip archive
  - From: Jeff Sturm
- Re: [PATCH] Java - allow compiling a compressed .jar/.zip archive
  - From: Per Bothner
- Re: [PATCH] Java - allow compiling a compressed .jar/.zip archive
  - From: Jeff Sturm

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]