This is the mail archive of the java@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] Java - allow compiling a compressed .jar/.zip archive


Jeff Sturm <jeff.sturm@commerceone.com> writes:

> This struct/buffer overlapping in read_zip_archive is ugly and
> fragile, clever as it may be.

I won't defend it very strongly.  It is probably faster and saves
some memory, but probably neither significantly so.    

I'm out of town so it is difficult to evaluate the best fix.
I have no objection to your fix, at least until we decide if
the code should be re-written.
-- 
	--Per Bothner
per@bothner.com   http://www.bothner.com/~per/

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]