This is the mail archive of the java-discuss@sources.redhat.com mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Java broken after i386 PIC change


On Sat, Jan 20, 2001 at 11:35:05PM -0800, Richard Henderson wrote:
> So it seems likely that there's some linkonce bug in 2.10 that
> has been fixed since.  I wonder how hard it would be to detect
> it at configure time.  Otherwise I've got to figure out some
> other solution to the original bug.

I've applied the following until I can figure out what
to do about detecting this at configure time.


r~


        * config/i386/i386.c (ix86_asm_file_end): Disable putting 
        pic_label_name in a linkonce section.

Index: i386.c
===================================================================
RCS file: /cvs/gcc/egcs/gcc/config/i386/i386.c,v
retrieving revision 1.206
diff -c -p -d -r1.206 i386.c
*** i386.c	2001/01/16 15:57:00	1.206
--- i386.c	2001/01/21 22:31:24
*************** Boston, MA 02111-1307, USA.  */
*** 40,45 ****
--- 40,46 ----
  #include "expr.h"
  #include "toplev.h"
  #include "basic-block.h"
+ #include "defaults.h"
  #include "ggc.h"
  
  #ifndef CHECK_STACK_LIMIT
*************** ix86_asm_file_end (file)
*** 1703,1709 ****
    if (! TARGET_DEEP_BRANCH_PREDICTION || pic_label_name[0] == 0)
      return;
  
! #ifdef ASM_OUTPUT_SECTION_NAME
    /* The trick here is to create a linkonce section containing the
       pic label thunk, but to refer to it with an internal label.
       Because the label is internal, we don't have inter-dso name
--- 1704,1713 ----
    if (! TARGET_DEEP_BRANCH_PREDICTION || pic_label_name[0] == 0)
      return;
  
!   /* ??? Binutils 2.10 and earlier has a linkonce elimination bug related
!      to updating relocations to a section being discarded such that this
!      doesn't work.  Ought to detect this at configure time.  */
! #if 0 && defined (ASM_OUTPUT_SECTION_NAME)
    /* The trick here is to create a linkonce section containing the
       pic label thunk, but to refer to it with an internal label.
       Because the label is internal, we don't have inter-dso name

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]