Re: [patch] Runtime.exec()

[Anthony Green <green@cygnus.com>]

Bryce wrote:
> This patch fixes a few problems in the Runtime.exec() implementation.

Please go ahead and commit this.  The only nit has to do with the
formatting of the ChangeLog entry.  We're following the GNU standard
here.

> 1999-06-02  Bryce McKinlay <bryce@albatross.co.nz>
> 
>         * java/lang/Runtime.java (exec): Convert prog name and arguments
> to string array
>         * java/lang/natPosixProcess.cc (startProcess): Fixed typo in
> environment array conversion, Preserve existing environment if envp not
> passed, Preserve PATH unless specified explicitly

...should look like...

1999-06-02  Bryce McKinlay <bryce@albatross.co.nz>

	* java/lang/Runtime.java (exec): Convert prog name and arguments
	to string array.
	* java/lang/natPosixProcess.cc (startProcess): Fixed typo in
	environment array conversion. Preserve existing environment if
	envp not passed. Preserve PATH unless specified explicitly.

Emacs' ChangeLog mode can format these correctly.  Consitency in the
ChangeLogs contributes to the long term maintainability of the code.

Your DataInputStream patch looks good also, although it will need a
ChangeLog entry.

Thanks!

AG

-- 
Anthony Green                                               Cygnus Solutions
                                                       Sunnyvale, California