This is the mail archive of the
java-prs@sources.redhat.com
mailing list for the Java project.
Re: gcj/321
- To: apbianco at cygnus dot com
- Subject: Re: gcj/321
- From: Jeff Sturm <jsturm at detroit dot appnet dot com>
- Date: 25 Aug 2000 18:16:01 -0000
- Cc: java-prs at sourceware dot cygnus dot com,
- Reply-To: Jeff Sturm <jsturm at detroit dot appnet dot com>
The following reply was made to PR gcj/321; it has been noted by GNATS.
From: Jeff Sturm <jsturm@detroit.appnet.com>
To: apbianco@redhat.com
Cc: bryce@albatross.co.nz, java-gnats@sourceware.cygnus.com
Subject: Re: gcj/321
Date: Fri, 25 Aug 2000 14:00:07 -0400
Alexandre Petit-Bianco wrote:
> Jeff Sturm writes:
> > Andrew posted a patch that should clear up any WORD_TO_INT problems:
> >
> > http://gcc.gnu.org/ml/gcc-patches/2000-08/msg00897.html
>
> Yes. I was also going to give this patch a bit of review and formal
> testing before approving it (though I'm pretty sure it's fine.)
Oh, that's OK... I meant to say "... if you approve the patch" but hit Send a
little too quick :\
My proposed fix (which you didn't see) typedef'ed jint as an `int' guaranteeing
it would be 32 bits on most (all?) platforms that can host GCC. Andrew left
jint alone, instead fixing WORD_TO_INT to be more tolerant of various integer
widths.
I don't have a strong opinion either way, except that "typedef long int32" is
nonintuitive to say the least... but Andrew's patch indeed fixes gcj/321 on
Alpha (didn't try it on IA32). Also there are too many pointer<->int
conversions in gcj for my comfort.
> > Alex, can you close this PR?
>
> I will. Oh, by the way, have you seen:
>
> http://gcc.gnu.org/ml/gcc-patches/2000-08/msg00907.html
Yes. I haven't looked closely at it... will try it when I get a chance.
Thanks.
--
Jeff Sturm
jeff.sturm@appnet.com