This is the mail archive of the
java-prs@sources.redhat.com
mailing list for the Java project.
Re: gcj/310
- To: tromey at cygnus dot com
- Subject: Re: gcj/310
- From: Tom Tromey <tromey at cygnus dot com>
- Date: 20 Aug 2000 01:50:00 -0000
- Cc: java-prs at sourceware dot cygnus dot com,
- Reply-To: Tom Tromey <tromey at cygnus dot com>
The following reply was made to PR gcj/310; it has been noted by GNATS.
From: Tom Tromey <tromey@cygnus.com>
To: apbianco@redhat.com
Cc: Java Gnats Server <java-gnats@sourceware.cygnus.com>
Subject: Re: gcj/310
Date: 19 Aug 2000 19:47:55 -0600
Alex> `boolean_type_node' is already covered by JINTEGRAL_TYPE_P used right
Alex> above your patch -- have you witnessed some improper behaviors with
Alex> booleans?
Thanks. How about this revised patch, which is much simpler?
2000-08-09 Tom Tromey <tromey@cygnus.com>
* parse.y (patch_switch_statement): Disallow `long' in switch
expressions. Fixes PR gcj/310.
Tom
Index: parse.y
===================================================================
RCS file: /cvs/gcc/egcs/gcc/java/parse.y,v
retrieving revision 1.200
diff -u -r1.200 parse.y
--- parse.y 2000/08/11 22:01:37 1.200
+++ parse.y 2000/08/20 01:38:52
@@ -14413,7 +14429,7 @@
se_type = TREE_TYPE (se);
/* The type of the switch expression must be char, byte, short or
int */
- if (!JINTEGRAL_TYPE_P (se_type))
+ if (! JINTEGRAL_TYPE_P (se_type) || se_type == long_type_node)
{
EXPR_WFL_LINECOL (wfl_operator) = EXPR_WFL_LINECOL (node);
parse_error_context (wfl_operator,