This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [PATCH] Fix FFI return type for closures in the java interpreter
- From: Tom Tromey <tom at tromey dot com>
- To: Tom Tromey <tom at tromey dot com>
- Cc: Matthew Fortune <Matthew dot Fortune at imgtec dot com>, "java-patches\ at gcc dot gnu dot org" <java-patches at gcc dot gnu dot org>, "'gcc-patches\ at gcc dot gnu dot org' \(gcc-patches\ at gcc dot gnu dot org\)" <gcc-patches at gcc dot gnu dot org>, "per\ at bothner dot com" <per at bothner dot com>, "aph\ at redhat dot com" <aph at redhat dot com>, Aurelien Jarno <aurelien at aurel32 dot net>
- Date: Tue, 28 Jun 2016 02:08:04 -0600
- Subject: Re: [PATCH] Fix FFI return type for closures in the java interpreter
- Authentication-results: sourceware.org; auth=none
- References: <6D39441BF12EF246A7ABCE6654B023537E45FD9F at HHMAIL01 dot hh dot imgtec dot org> <87shvyib1n dot fsf at tromey dot com>
>>>>> "Matthew" == Matthew Fortune <Matthew.Fortune@imgtec.com> writes:
Matthew> I've identified a latent bug in the java interpreter that affects MIPS
Matthew> n32 and n64 ABIs both little and big endian and, I presume, any 64-bit
Matthew> big endian target with int as 32-bit.
[...]
Matthew> libjava/
Matthew> * interpret-run.cc: Use ffi_arg for FFI integer return types.
Matthew> libjava/testsuite/
Matthew> * libjava.jar/arraysort.java: New file.
Matthew> * libjava.jar/arraysort.jar: New file.
Matthew> * libjava.jar/arraysort.out: New file.
Matthew> * libjava.jar/arraysort.xfail: New file.
Tom> This is ok.
It occurred to me that this might not be correct on platforms using the
Java raw API; which I think is just x86.
I'm actually not sure -- I don't remember (if I ever knew) if the raw
API has the same return-value promotion rules as the ordinary API.
Could you check? I think a -m32 build ought to show it. Maybe your
x86-64 build already did this?
thanks,
Tom