This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
The c-opts.c change to include tm.h seems independent of the rest of the patch, and is incorrect since the file already has an explicit tm.h include with a comment saying why it's included.
Yes, I've left this bit out now. It used to be necessary, but it has been obsoleted by your c-opts.c patch last month.
I think it would be a good idea for the java/expr.c include (which I can't approve, Java patches should best be CC:ed to java-patches) to have a comment saying what target macros are used
Similar comments also apply to the fortran/trans-types.c change: send to the fortran list as well as gcc-patches, include a comment listing the target macros involved (BOOL_TYPE_SIZE CHAR_TYPE_SIZE DOUBLE_TYPE_SIZE FLOAT_TYPE_SIZE INT_TYPE_SIZE LIBGCC2_HAS_TF_MODE LONG_DOUBLE_TYPE_SIZE LONG_LONG_TYPE_SIZE LONG_TYPE_SIZE POINTER_SIZE SHORT_TYPE_SIZE SIZE_TYPE).
Attachment:
pr46500-patch-20110507-2.gz
Description: GNU Zip compressed data
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |