Re: [PATCH] Normalization of Java sources

[Mark Wielaard <mark at klomp dot org>]

On Tue, 2011-01-11 at 14:33 +0000, Dr Andrew John Hughes wrote:
> > yeah, if it keeps libgcj and classpath in sync then please do it to
> > both, but only for those files really necessary. If you do please do
> > update the hacking guides. This change makes us use even more non-gnu
> > standard coding style (2 and I think 4 seems not according to the
> > current style):
> > http://www.gnu.org/software/classpath/docs/cp-hacking.html#SEC10
> > Files under classpath/doc/cp-hacking.texinfo
> > 
> 
> I reviewed the style guidelines both at the time and just now.  Can
> you point me to where you think this contradicts them?  I believe it
> does require 2 *space* indentation, which would contradict the use of
> tabs.
> 
> My reading of them is that they don't say either way.

Seems you are right. How odd, I was pretty sure it said to use tabs for
indentation whenever possible. This is what the default emacs c-mode,
which will do. Use tabs for indentation whenever a multiple of 8 spaces
is needed (padded with actual space characters). So it would be good to
at least document somewhere we are now requiring (setq indent-tabs-mode
nil).

Cheers,

Mark