This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Miscellaneous diagnostics cleanup
- From: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org, java-patches at gcc dot gnu dot org
- Date: Thu, 11 Nov 2010 10:32:54 -0800
- Subject: Re: Miscellaneous diagnostics cleanup
- References: <Pine.LNX.4.64.1011102323020.19837@digraph.polyomino.org.uk>
On Wed, Nov 10, 2010 at 11:30:58PM +0000, Joseph S. Myers wrote:
>
> As Fortran appears to use uppercase at the start of diagnostics
> deliberately, I didn't change diagnostics there for that issue, and nor
> did I change them for trailing '.'. The only Fortran changes were use of
> the "front-end" spelling convention and adding a space between two words
> that was missing where string concatenation was used.
>
>
> fortran:
> 2010-11-10 Joseph Myers <joseph@codesourcery.com>
>
> * trans-array.c (gfc_trans_deferred_array): Use "front-end"
> spelling in diagnostic.
> * trans.c (gfc_allocate_array_with_status): Add missing space in
> diagnostic.
>
The gfortran bits are are OK.
As to the convention used in gfortran, this was the style in use
when g95 was imported long ago. We, the gfortan developers, simply
maintained that style so that error message had a uniform appearance.
If it is the consensus of the GCC community to have a uniform
appearance for error message across GCC, then I see no reason
that gfortran cannot adopt the lowercase initial word and the
trailing period. The changes can be implemented in stages.
laptop:kargl[204] grep gfc_error *.c | wc -l
1504
laptop:kargl[205] grep gfc_warn *.c | wc -l
152
laptop:kargl[206] grep _fatal *.c | wc -l
48
--
steve