This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [PATCH] Re: libjava broken on the trunk on i386-darwin8.11
- From: Andrew Haley <aph at redhat dot com>
- To: Dave Korn <dave dot korn dot cygwin at googlemail dot com>
- Cc: Andrew Pinski <pinskia at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Java Patches <java-patches at gcc dot gnu dot org>
- Date: Wed, 30 Sep 2009 14:56:59 +0100
- Subject: Re: [PATCH] Re: libjava broken on the trunk on i386-darwin8.11
- References: <de8d50360909291615r2b2503bfp19911fdbf09acf45@mail.gmail.com> <de8d50360909291621m7847d21ej2b6198c95106fe7b@mail.gmail.com> <4AC29F50.8090509@gmail.com> <4AC2B8C7.4030609@gmail.com> <4AC36531.10405@gmail.com>
Dave Korn wrote:
> Dave Korn wrote:
>
>> I'm now bootstrapping this. Andrew, would you like to check if it fixes
>> your problem on Darwin?
>
> As we see upthread, the first spin lacked some quoting. Here's the fixed
> version, tested by blowing away the $target/libjava directory and rebuilding
> with "make configure-target-libjava all-target-libjava install-target-libjava"
> (using DESTDIR for the install stage). Build completed successfully and
> verified manually that the correct definition of LIBGCJ_SUBLIB_LTFLAGS made it
> into the generated $target/libjava/Makefile and the correct files got
> installed into the correct locations in the DESTDIR, for
> target=i686-pc-cygwin. Same ChangeLog as before:
>
>> libjava/ChangeLog:
>>
>> * configure.host (libgcj_sublib_ltflags): New variable.
>> * configure.ac (LIBGCJ_SUBLIB_LTFLAGS): AC_SUBST variable for
>> the above in makefiles.
>> * configure: Regenerate.
>>
>> * Makefile.am (libgcj_la_LDFLAGS_NOUNDEF): Rename from this ...
>> (LIBJAVA_LDFLAGS_NOUNDEF): ... to this, initialise from
>> LIBGCJ_SUBLIB_LTFLAGS (only when building sublibs), and ...
>> (libgij_la_LDFLAGS, libgcj_tools_la_LDFLAGS, libjvm_la_LDFLAGS,
>> lib_gnu_awt_xlib_la_LDFLAGS, libgcj_bc_la_LDFLAGS): ... use it in
>> all these places to replace hard-coded -no-undefined and -bindir
>> flags, as well as ...
>> (libgcj_la_LDFLAGS): ... updating existing reference here.
>> * Makefile.in: Regenerate.
>> * include/Makefile.in: Likewise.
>> * testsuite/Makefile.in: Likewise.
>> * gcj/Makefile.in: Likewise.
>
> Tests running now, assuming no regressions OK for head?
Sure. Andrew Pinski, is this OK?
Andrew.