This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [PATCH, take 2] Build java as two separate DLLs on windows.
Dave Korn wrote:
> Andrew Haley wrote:
>> Dave Korn wrote:
>>
>>> Here's the final version of my libjava-as-dlls patch. Nobody had anything
>>> much to say about the first draft so I take it there were no obvious massive
>>> flaws;
>> No, you take it that I was AFK for a few days and didn't have the time
>> to look at it.
>
> Well not exactly, I had no idea where you were, I'm not following you
> around, honest! (And I was including other maintainers from both java and gcc
> sides in that reference, nobody else volunteered an opinion either. It wasn't
> in any way a pointed comment directed at you personally.)
Sure, I know. At this time of year reviewing can get a bit slow. :-)
>>> Bootstrapped at -j4 on i686-pc-cygwin. Tests currently running, results
>>> anticipated in a few hours. Assuming (as I have every reason to expect) no
>>> regressions, OK for HEAD?
>> Please wait for approval.
>
> Of course, I thought that went without saying. When I write "OK for HEAD?",
> it is a request for review and approval, so I thought that's exactly what I
> was doing already. (I don't actually go round checking stuff in without
> permission do I?)
Don't take it wrong: I'm not complaining, just explaining.
I also wanted to let the other gcj maintainers know that I am interested in
this patch and will try to review it.
Andrew.