This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/?] Fix PR38892: "--enable-libgcj-debug" breaks bootstrap.


>>>>> "Dave" == Dave Korn <dave.korn.cygwin@googlemail.com> writes:

Dave>   The attached patch fixes the first build problem I run into
Dave> after turning on "--enable-libgcj-debug":

I guess we don't do this often :)

Dave> libjava/ChangeLog:
Dave> 	* gnu/classpath/jdwp/natVMVirtualMachine.cc (handle_single_step):  Use
Dave> 	casted pointer in debugging assert.
Dave> 	(jdwpBreakpointCB):  Likewise.

This is ok, thanks.

Dave> that maybe it's entirely superfluous now as the reinterpret_cast
Dave> will throw a typeinfo exception if we pass the wrong kind of
Dave> frame object to it, won't it?

I don't think reinterpret_cast can throw, only dynamic_cast.  If it
can throw then it will probably just make the thread exit.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]