This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: PATCH RFA: -Wc++-compat warnings for assignments to enum variables
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Ian Lance Taylor <iant at google dot com>
- Cc: gcc-patches at gcc dot gnu dot org, java-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org
- Date: Wed, 22 Apr 2009 21:43:45 +0000 (UTC)
- Subject: Re: PATCH RFA: -Wc++-compat warnings for assignments to enum variables
- References: <m3ab6875tm.fsf@google.com>
On Wed, 22 Apr 2009, Ian Lance Taylor wrote:
> There are two patches here. The first, smaller, patch enables the
> warning. The main work here is to add a parameter to build_modify_expr,
> so that we can emit warnings for assignments to bitfields in structs
> with enum type. The additional parameter is required because at the
> point of convert_for_assignment, the original enum type has been
> replaced by a bitfield integer type. This patch requires approval from
> the C and C++ frontend maintainers. Please also take a quick look at
> the new test case, and let me know if there are any other cases I should
> check.
The C changes are OK.
--
Joseph S. Myers
joseph@codesourcery.com