This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Remove data race in libgcj interpreter

David Daney wrote:
> Andrew Haley wrote:
>> +
>> + #ifdef DIRECT_THREADED
>> +     CHECK_INSN (&&insn_instanceof);
>> + #endif /* DIRECT_THREADED */
>> +
> 
> Just a little style pedantry...
> 
> Should we re-write the CHECK_INSN macro so that it is a nop ifndef
> DIRECT_THREADED?
> 
> That would make the many places you have this construct look much cleaner.

OK, but would it be easier to understand when reading the code?  That's
why I didn't do that.  Sometimes clarity and cleanliness don't go
together.  What do you think?

Andrew.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]