This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Remove data race in libgcj interpreter

From: David Daney <ddaney at avtrex dot com>
To: Andrew Haley <aph at redhat dot com>
Cc: Java Patch List <java-patches at gcc dot gnu dot org>
Date: Thu, 04 Sep 2008 09:00:06 -0700
Subject: Re: Remove data race in libgcj interpreter
References: <48AD67B2.4040308@redhat.com> <48C0042C.5080804@redhat.com>

Andrew Haley wrote:

+
+ #ifdef DIRECT_THREADED
+ 	CHECK_INSN (&&insn_instanceof);
+ #endif /* DIRECT_THREADED */
+

Just a little style pedantry...

Should we re-write the CHECK_INSN macro so that it is a nop ifndef DIRECT_THREADED?

That would make the many places you have this construct look much cleaner.

David Daney

Follow-Ups:
- Re: Remove data race in libgcj interpreter
  - From: Andrew Haley

References:
- Remove data race in libgcj interpreter
  - From: Andrew Haley
- Re: Remove data race in libgcj interpreter
  - From: Andrew Haley

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]