This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] libffi, fix powerpc-unknown-freebsd


On Sun, Aug 24, 2008 at 4:08 PM, Andreas Tobler <andreast-list@fgznet.ch> wrote:

> I have an understanding issue here, what bits are you referring to? The
> FLAG_SYSV_SMST_R4 and FLAG_SYSV_SMST_R3 from ffi.c?
> Or the situation that I use FFI_SYSV_TYPE_SMALL_STRUCT and the two flags?
> If the former, then my impression is that they don't need to be mentioned in
> ffitarget.h, otherwise we'd have to describe every flag used in ffi.c in
> ffitarget.h as well.
> If the latter, I can put a note into ffitarget.h mentioning that we need
> additional separation in ffi.c to clearly distinguish what we return.

FLAG_SYSV_TYPE_SMALL_STRUCT uses two bits in flags, if I understand
the code correctly.  I think it would be helpful to note that in
ffitarget.h

Thanks, David


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]