Re: [patch] Create sdk style directory on install

[Joshua Sumali <jsumali at redhat dot com>]

Matthias Klose wrote:
> Joshua Sumali schrieb:
>   
> > Hi,
> >
> > Attached is a patch to create a sdk style directory when
> > --enable-java-home is passed to configure. The patch is basically a
> > merge of java-gcj-compat into libgcj.
> >
> > To have this work, at the minimum, pass the following to ./configure:
> > --enable-java-home --with-arch-directory=(your arch).
> > --with-arch-directory specifies what to use for the
> > java-1.5.0-gcj-1.5.0.0/jre/lib/<arch> directory (e.g. I use i386).
> >
> > I've only included the diff to configure.ac and Makefile.am since
> > including the configure and Makefile.in makes the patch quite big, so be
> > sure to autoconf && automake before trying this patch. I can upload the
> > renerated files somewhere if it's absolutely needed, though.
> >     
>
> - please use `transform' to install the binaries; just using gcc_suffix is
>   inconsistant with current installation. Same for using GIJ_VERSION.
>   
I will look into this.
> - symlinks for man pages are not installed. intended?
>   
I don't think this was part of java-gcj-compat, so it is not included in 
my patch.
> - + for jarname in jaas jce jdbc-stdext jndi jndi-cos jndi-dns ...
>   I think this is fedora specific to support jpackage?  It doesn't hurt
>   to have these symlinks. Maybe the same should be added for IcedTea?
>
> - Is the --with-arch-directory really needed? Shouldn't we just use the
>   default.
>   
Yes, I believe this is necessary for different archs when building an 
rpm. I can't remember off the top of my head, but for x86 the directory 
is jre/lib/i386 and x86_64 is perhaps x86_64 or amd64. Anyways, the 
java-1.5.0-gcj spec file shows configure with 
"--with-arch-directory=%{_arch}".
> +
> jre_dir=java-${JAVA_VERSION}-${origin_name}-${JAVA_VERSION}.${BUILD_VERSION}${arch_suffix}/jre
> +
> sdk_dir=java-${JAVA_VERSION}-${origin_name}-${JAVA_VERSION}.${BUILD_VERSION}${arch_suffix}
> +  jre_lnk=jre-${JAVA_VERSION}-${origin_name}
> +  sdk_lnk=java-${JAVA_VERSION}-${origin_name}
>
> why using the long version at all? 
I can't provide an exact answer, as I have just merged what was in 
java-gcj-compat into this patch. Perhaps fitzsim could provide insight, 
but I think for Fedora at least, we use the long version (sdk_dir) for 
jvm installs.
> afaik no packaging allows installation of two
> such packages at the same time (with same jre_link and different jre_dir's). 
What do you mean by "same jre_link and different jre_dir" exactly?
> And
> it makes it difficult for people writing into the ext subdirectory because this
> changes across minor version upgrades
> - The new configure options should be documented in gcc/doc/install.texi
>   (and maybe something about the jpackage compatible (?) layout).
>   
Sure, I can do this.
> - what is the rationale of --with-jvm-jar-dir ?
>   
It's to provide some control as to where we're installing the jar 
symlinks. Default is /usr/lib/jvm-exports, but I'm not sure if this is 
consistent across all distros, so I think it's nice to have an option to 
change this location.
> Matthias
>