Re: [PATCH] build fix when source tree is fully read-only

["Andrew John Hughes" <gnu_andrew at member dot fsf dot org>]

On 27/02/2008, Andrew Haley <aph@redhat.com> wrote:
> Tom Tromey wrote:
>  >>>>>> "Tom" == Tom Tromey <tromey@redhat.com> writes:
>  >
>  > Jan> 2008-02-26  Jan Beulich  <jbeulich@novell.com>
>  > Jan> * classpath/tools/Makefile.am ($(TOOLS_ZIP)): Make tree
>  > Jan> writeable before attempting to remove them.
>  > Jan> * classpath/tools/Makefile.in: Re-generate.
>  >
>  > Tom> Ok, thanks.
>  >
>  > Andrew tells me he rejected this -- but I didn't see the mail.  So,
>  > let's let that stand instead.
>
>
> jan replied to me, saying
>
>
>  "It's *not* the source tree that gets altered, but the copy made for
>  creating tools.zip. That copy, as said in the description, gets deleted
>  immediately afterwards anyway, so what would be the purpose of
>  insisting of retaining the attributes (which result only from 'cp -pR'
>  used earlier in the rule."
>
>
> I never replied to that, because Jan's mail never reached my inbox,
>  sorry.  It's in the archive tho'.
>
>
>  Andrew.
>
>
>

The problem here seems odd to me.  Why are these directories and their
contents being created as read-only?  If that itself is a build issue,
should it not be corrected rather than its result (giving an
unnecessary chmod on all runs)?  If the tree has been changed manually
by the user to read only, then, as Andrew says, we shouldn't override
that.
-- 
Andrew :-)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net