This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [Patch 2/2] Make java compiled resources public.
- From: Tom Tromey <tromey at redhat dot com>
- To: David Daney <ddaney at avtrex dot com>
- Cc: Java Patch List <java-patches at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Sat, 19 Jan 2008 11:05:55 -0700
- Subject: Re: [Patch 2/2] Make java compiled resources public.
- References: <478C061B.1040003@avtrex.com> <478C0AFD.4040203@avtrex.com>
- Reply-to: Tom Tromey <tromey at redhat dot com>
>>>>> "David" == David Daney <ddaney@avtrex.com> writes:
David> OK to commit?
There are some whitespace problems with this patch, but otherwise it
is ok. Thanks.
Also, would you mind replying to Gerald's notes on the documentation
patch? I didn't see a reply to that.
David> +static void
David> +append_resource_name_hunk(const unsigned char *hunk, int len)
Space before '('.
David> + unsigned char *n = (unsigned char *)alloca (2 * len + 1);
Space after ')'.
David> + ch = UTF8_GET(w1, limit);
...
David> + append_gpp_mangled_name ((char *)n, d - n);
...
David> + const unsigned char *limit = (const unsigned char *)name + strlen(name);
...
David> + ch = UTF8_GET(ptr, limit);
...
Tom