Re: [boehm-gc] Define HBLKSIZE to 4096 for MIPS

[Hans Boehm <Hans dot Boehm at hp dot com>]

It also looks like a good idea to me.  The collector assumes that
the page size is a multipe of HBLKSIZE, so we should probably
change this on some other platforms with configurable page sizes
as well.

I missed the first part of this discussion, and can't immediately find
it.  Did this result in failures outside the collector test itself?
I would have expected this to affect only incremental GC, which
I thought was still hard to use with gcj?

Hans

On Fri, 4 Jan 2008, David Daney wrote:

> Richard Sandiford wrote:
> > 4096 is the default (and smallest) page size for both 32-bit and 64-bit
> > MIPS Linux, so I'd like to use it as the default HBLKSIZE for both.
> > The definition in patch below overrides the target-independent LP64
> > default of 8k and copies similar definitions for other 64-bit Linux
> > targets.
>
> Thanks.  I thought it might be something like this.
>
>
> > Tested on mips64-linux-gnu, where it fixes all remaining n64 libjava
> > failures on QEMU.  (The o32 and n32 results are clean before and after
> > the patch.)  OK to install?
>
> Forwarding to java-patches@ where they often consider patches to GCC's
> copy of boehm-gc.
>
> FWIW, I recommend approving the patch.
>
> David Daney
>
> > Richard
> >
> >
> > boehm-gc/
> >       * include/private/gcconfig.h (HBLKSIZE): Define for MIPS.
> >
> > Index: boehm-gc/include/private/gcconfig.h
> > ===================================================================
> > --- boehm-gc/include/private/gcconfig.h       2007-12-31 15:25:41.000000000 +0000
> > +++ boehm-gc/include/private/gcconfig.h       2007-12-31 15:25:50.000000000 +0000
> > @@ -1375,6 +1375,9 @@
> >  #     else
> >  #    define ALIGNMENT 4
> >  #     endif
> > +#     ifndef HBLKSIZE
> > +#       define HBLKSIZE 4096
> > +#     endif
> >  #     define USE_GENERIC_PUSH_REGS
> >  #     if __GLIBC__ == 2 && __GLIBC_MINOR__ >= 2 || __GLIBC__ > 2
> >  #        define LINUX_STACKBOTTOM