Re: [patch] darwin full x86_64 and i?86 libjava support

[Andrew Haley <aph at redhat dot com>]

Andreas Tobler writes:
 > Andrew Haley wrote:
 > > Andreas Tobler writes:
 > >  > 
 > >  > 
 > >  > Thanks for review and feedback,
 > > 
 > > Your formatting is FUBAR in a few places:
 > 
 > :(
 > 
 > > This is kinda horrible:
 > 
 > Tried to make it better, see below.
 > 
 > >  > +#if defined (__LP64__)
 > >  > +  fde = getsectdatafromheader_64(
 > >  > +#else
 > >  > +  fde = getsectdatafromheader(
 > >  > +#endif
 > >  > +			      mh, "__DATA", "jcr", &sz);
 > > 
 > > Remember spaces between function names and arg lists.
 > 
 > Fixed.
 > 
 > > Otherwise OK.
 > 
 > Thanks!
 > 
 > Is the below a better approach? I'm not sure how much I can modify 
 > existing code when it only belongs to formatting.

That looks much better, thanks.  I was only asking you not to make
formatting worse, I wasn't asking you to fix what's there already.

Andrew.

-- 
Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, UK
Registered in England and Wales No. 3798903