Re: [Patch] libffi: Fixes for MIPS n32 ABI.

[Richard Sandiford <rsandifo at nildram dot co dot uk>]

David Daney <ddaney@avtrex.com> writes:
> Richard Sandiford wrote:
>> ...you're talking about ffi_raw vs. _Jv_word, right?
>
> Correct.
>
>> As far as
>> reviewing the patch goes, I'll sign off on the former being 8 bytes
>> and the latter being 4,
>
> That was the state for n32 before the patch and the cause of the problems.

Right.  Sorry for being ambiguous (twice in two days!).  I meant:
I agree that the problem you describe exists for n32, and that it
needs to be fixed.  (As far as I could tell, that was the only really
target-specific item of interest here, so I thought it was the only
reviewing input I was qualified to give.)

>> But why doesn't the ffi_java_raw_* API use a separate union that matches
>> the layout of _Jv_Word on all targets? 
>
> That is what my new patch will do.

OK, great.

Richard