This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] libffi: Add MIPS64 support.


Maciej W. Rozycki wrote:
On Thu, 9 Aug 2007, Richard Sandiford wrote:

In the first case, you are probably correct. We are copying the pointer into a wider type. In practice it does not matter because all valid user space pointers have the high bit clear so there would never be a case where the not sign extending would produce a different result than if you did sign extend.
Ah, so we don't support running libffi from kernel space?  I was assuming
we needed to cope with both.  If we don't, it is indeed a non-issue.

It sounds like carelessness to me -- I would watch out.

Indeed. I will fix it before committing.


David Daney


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]