This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch] libffi testsuite: Use correct type specifiers.

From: Andreas Tobler <toa at pop dot agri dot ch>
To: David Daney <ddaney at avtrex dot com>
Cc: GCJ-patches <java-patches at gcc dot gnu dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>, andreast at gcc dot gnu dot org
Date: Wed, 08 Aug 2007 20:06:13 +0200
Subject: Re: [Patch] libffi testsuite: Use correct type specifiers.
References: <46B94EFA.1@avtrex.com>

David Daney wrote:

As noted in my previous message:
http://gcc.gnu.org/ml/java-patches/2007-q3/msg00126.html
The libffi testsuite has many places where the wrong type specifier is used. This patch corrects all the erroneous specifiers that I could find. Also there was a definition in ffitest.h for ffi_type_mylong that exactly mirrored a standard type definition found in ffi.h, so I removed it and used the correct standard specifier instead.

Most of the test cases were born before the libffi reorg from Paolo B. and rth came in, that was back in october 03. When I committed the test cases I did not notice the double definition. Sorry.

Tested on x86_64-pc-linux-gnu (both native and -m32 ABIs) and mips64-linux with no failures.

OK to commit?

I think yes. Will see if there are fallouts on other platforms. And if so you might have uncovered a bug there ;)

Thank you David!

Andreas

References:
- [Patch] libffi testsuite: Use correct type specifiers.
  - From: David Daney

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]