This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [Patch] libffi testsuite: Use correct type specifiers.
- From: Andrew Haley <aph-gcc at littlepinkcloud dot COM>
- To: David Daney <ddaney at avtrex dot com>
- Cc: GCJ-patches <java-patches at gcc dot gnu dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>, andreast at gcc dot gnu dot org
- Date: Wed, 8 Aug 2007 10:00:13 +0100
- Subject: Re: [Patch] libffi testsuite: Use correct type specifiers.
- References: <46B94EFA.1@avtrex.com>
David Daney writes:
> As noted in my previous message:
> http://gcc.gnu.org/ml/java-patches/2007-q3/msg00126.html
>
> The libffi testsuite has many places where the wrong type specifier is
> used. This patch corrects all the erroneous specifiers that I could
> find. Also there was a definition in ffitest.h for ffi_type_mylong that
> exactly mirrored a standard type definition found in ffi.h, so I removed
> it and used the correct standard specifier instead.
>
> Tested on x86_64-pc-linux-gnu (both native and -m32 ABIs) and
> mips64-linux with no failures.
>
> OK to commit?
Some of these don't look right. For example, cls_align_sint32.c is
supposed to check structure alignment of sint32, but you changed it to
int. It would make more sense to change "signed int" to sint32_t,
wouldn't it? Then the test would actually be doing what it says it's
supposed to do.
Andrew.