Re: 4.1/4.2/4.3 PATCH: Switch boehm-gc to pthreads on Solaris (boehm-gc/21940, boehm-gc/21942)

[Andreas Tobler <toa at pop dot agri dot ch>]

Hi Rainer,

Rainer Orth wrote:
> Andreas Tobler writes:
>
> > I tried this patch on solaris8 sparc and I saw an improvement in the 
> > libgcj test (32 and 64 bit). But I hang in the gctest. I might debug 
> > next week.
>
> After manually working around the hang with the alternate thread library in
> /usr/lib/lwp, I've now a clean patch which uses it.  One can easily use gcc
> -print-multi-os-directory to detect the /usr/lib/lwp subdir corresponding
> to the current multilib.


Thanks a lot for this work. And sorry for the delay. I was on vacation.

I can confirm that it works here too on my multilib sparc solaris 8 build.



> Here's the revised patch, tested with
>
> make configure-target-boehm-gc
> make check
>
> on Solaris 8 for both multilibs.  I have to explicitly link with -lthread,
> otherwise the default version in /usr/lib is used: libpthread is a filter
> library, and its dependencies are only searched in LD_LIBRARY_PATH and the
> RPATH/RUNPATH encoded in the affected library (libpthread, i.e. none).
> This is confirmed on threads(3THR), which specifies
>
> 	cc -mt ... -lpthread ... -R/usr/lib/lwp
>
> where -mt expands to -lthread.
>
> The other change is to use THREADLIBS instead of THREADDLLIBS in
> gctest_LDADD so the proper flags are passed to the gctest link.  This is
> probably a merge error from upstream, where the variable is called
> THREADDLLIBS in gc6.8.
>
> I suppose this modified patch is still ok for 4.1/4.2/4.3?

It looks ok for me, although I have no approval rights. But afair, 
Andrew approved your previous one. And this one is an improvement over 
the first one.

Thanks again,

Andreas