Re: Pointer Plus Patch

[Paolo Bonzini <bonzini at gnu dot org>]

Richard Guenther wrote:
> On 6/13/07, Paolo Bonzini <bonzini@gnu.org> wrote:
> > > !           = convert (sizetype,
> > >                        size_diffop (size_zero_node, gnu_pos));
> >
> > Use fold_convert instead.
>
> In fact, the convert is useless now, just remove it.
>
> > >             gnu_ptr = convert (gnu_char_ptr_type, gnu_ptr);
> >
> > Well, I'd use it here too but that's your call.
> >
> > > !       return build_binary_op (POINTER_PLUS_EXPR, type, expr,
> > > !                               fold (convert (sizetype, byte_diff)));
> > >       }
> >
> > Just use fold_convert here too, as byte_diff is returned from
> > size_diffop here too.
>
> just omit it as well.

No, size_diffop returns an ssizetype unless I read it wrong.

Paolo